Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce SelectiveConsumer #176

Merged
merged 13 commits into from
Dec 24, 2020
Merged

Introduce SelectiveConsumer #176

merged 13 commits into from
Dec 24, 2020

Conversation

ono
Copy link
Collaborator

@ono ono commented Dec 24, 2020

Introduce our own implementation of SelectiveConsumer. The module replaces the Receiver module and is managed under amqp_client channel's supervision tree. The changes will achieve more reliable structure and eliminate unnecessary processes/middle brokers.

Additionally the PR introduces the following changes:

  • Rename no_wait option to nowait to be consistent with Erlang library
  • Fix the issue the library doesn't handle nowait option well

@ono ono mentioned this pull request Dec 24, 2020
10 tasks
@ono ono merged commit a180b41 into pre/v2.0 Dec 24, 2020
@ono ono deleted the feature/selective-consumer branch December 24, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant